Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to include acknowledgements to llama.cpp #3700

Closed
wants to merge 1 commit into from

Conversation

survirtual
Copy link

resolves #3697

@mchiang0610
Copy link
Contributor

@survirtual thank you for submitting this. We definitely need to do a better job acknowledging the work of @ggerganov and the llama.cpp team.

Maybe we should create a backend engine section? llama.cpp definitely will not be the only engine Ollama uses.

We spend a large chunk of time fixing and patching it up to ensure a smooth experience for Ollama users and developers. We don't promise exact features as llama.cpp. This is due to potential breaking changes in it. As a developer tool, we try very hard to keep Ollama running. We don't always get it right, but we try.

Overtime, we will be transitioning to more systematically built engines.

@mchiang0610
Copy link
Contributor

added it here! Thank you so much for this PR

9755cf9

@survirtual
Copy link
Author

@survirtual thank you for submitting this. We definitely need to do a better job acknowledging the work of @ggerganov and the llama.cpp team.

Maybe we should create a backend engine section? llama.cpp definitely will not be the only engine Ollama uses.

We spend a large chunk of time fixing and patching it up to ensure a smooth experience for Ollama users and developers. We don't promise exact features as llama.cpp. This is due to potential breaking changes in it. As a developer tool, we try very hard to keep Ollama running. We don't always get it right, but we try.

Overtime, we will be transitioning to more systematically built engines.

A well documented backend engine section would be a good idea.

While there is still only 1 supported engine, I'd really recommend providing front & center llama.cpp acknowledgements (along the vein of the pull request I provided) to curate good will with people who may have a sour taste (along with all the other reasons listed before on the original issue). Once more engines are added, it will be more natural to shift the verbiage around.

Many people rely on this project now and it has done wonders to make open-weight LLMs more ergonomic, so I don't like seeing such a simple thing weigh it down. As it stands with the change you've merged, while an improvement, may be perceived badly since it is all the way at the bottom with a single line. It might be better to remove any chance of that negative perception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No llama.cpp acknowledgement
2 participants