update create handler to use model.Name #3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxyng
force-pushed
the
mxyng/modelname-3
branch
from
c012dbb
to
b49dea6
Compare
mxyng
force-pushed
the
mxyng/modelname-4
branch
2 times, most recently
from
38bc91b
to
a94c401
Compare
bmizerany
reviewed
Apr 19, 2024
mxyng
force-pushed
the
mxyng/modelname-3
branch
8 times, most recently
from
b2d8c1a
to
075bb09
Compare
mxyng
force-pushed
the
mxyng/modelname-4
branch
3 times, most recently
from
bb98227
to
898d0a8
Compare
mxyng
force-pushed
the
mxyng/modelname-3
branch
2 times, most recently
from
1cdbfc3
to
6a10185
Compare
mxyng
force-pushed
the
mxyng/modelname-4
branch
2 times, most recently
from
802b2ad
to
69c0caf
Compare
BruceMacD
reviewed
May 10, 2024
There was a problem hiding this comment.
Not a blocking bug, but I am unable to create a model in the default (library) namespace with this change. Maybe this should never have worked though:
./ollama create localhost:6000/nous-hermes-2-mistral -f /Users/bruce/models/nous-hermes-2-mistral/Modelfile
transferring model data
Error: invalid model name
322c7dc
to
5013cd0
Compare
you're setting host and model so this name is indeed not valid. to set host, you must also set namespace |
mxyng
force-pushed
the
mxyng/modelname-3
branch
4 times, most recently
from
8e957a7
to
c5e892c
Compare
mxyng
force-pushed
the
mxyng/modelname-4
branch
3 times, most recently
from
0e4d81e
to
d6d22ba
Compare
BruceMacD
reviewed
Jun 4, 2024
| if c.Name != "license" { | ||
| // replace | ||
| layers = slices.DeleteFunc(layers, func(layer *Layer) bool { | ||
| return layer.MediaType == mediatype | ||
| if layer.MediaType != mediatype { |
There was a problem hiding this comment.
What's this logic change for? Doesnt seem related
There was a problem hiding this comment.
This is fixing a bug the new tests found. What's happening is on a template or system override, the layer being overwritten isn't being removed
BruceMacD
approved these changes
Jun 5, 2024
BruceMacD
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #3718