Wire up load progress #4547
Merged
Wire up load progress #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't expose a UX yet, but wires the initial server portion of progress reporting during load
jmorganca
approved these changes
May 23, 2024
|
so fast progress cheers to all great contributors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't expose a UX yet, but wires the initial server portion of progress reporting during load
TODO
expose progress inUX can come in a follow up PRollama runexpose percent loaded inUX can come in a follow up PRollama psFixes #4350
Replaces #4123 #4419
This should provide a good balance between slow model loads vs. detecting stalls without taking too long before giving up.