Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go test./... issue: fmt.Println arg list ends with redundant newline #705

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

xyproto
Copy link
Contributor

@xyproto xyproto commented Oct 4, 2023

go test ./... currently fails with:

# github.com/jmorganca/ollama/cmd
cmd/cmd.go:690:7: fmt.Println arg list ends with redundant newline
cmd/cmd.go:698:7: fmt.Println arg list ends with redundant newline
cmd/cmd.go:704:7: fmt.Println arg list ends with redundant newline
cmd/cmd.go:710:7: fmt.Println arg list ends with redundant newline
?       github.com/jmorganca/ollama     [no test files]
?       github.com/jmorganca/ollama/api [no test files]
?       github.com/jmorganca/ollama/llm [no test files]
?       github.com/jmorganca/ollama/llm/llama.cpp       [no test files]
?       github.com/jmorganca/ollama/parser      [no test files]
?       github.com/jmorganca/ollama/progressbar [no test files]
ok      github.com/jmorganca/ollama/format      0.003s
?       github.com/jmorganca/ollama/vector      [no test files]
?       github.com/jmorganca/ollama/version     [no test files]
ok      github.com/jmorganca/ollama/server      0.005s
FAIL

This commit changes fmt.Println to just fmt.Print so that go test ./... passes:

?       github.com/jmorganca/ollama     [no test files]
?       github.com/jmorganca/ollama/api [no test files]
?       github.com/jmorganca/ollama/cmd [no test files]
?       github.com/jmorganca/ollama/llm [no test files]
?       github.com/jmorganca/ollama/llm/llama.cpp       [no test files]
?       github.com/jmorganca/ollama/parser      [no test files]
?       github.com/jmorganca/ollama/progressbar [no test files]
ok      github.com/jmorganca/ollama/format      (cached)
?       github.com/jmorganca/ollama/vector      [no test files]
?       github.com/jmorganca/ollama/version     [no test files]
ok      github.com/jmorganca/ollama/server      (cached)

I'm on Arch Linux using Go 1.21.1 linux/amd64.

Copy link
Contributor

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants