-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
acbeb5e
commit 3017ad1
Showing
5 changed files
with
86 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# Contributing to cl-dotenv | ||
|
||
## Prerequisites | ||
- Git | ||
- [SBCL](http://www.sbcl.org/) | ||
- [Roswell](https://github.com/roswell/roswell) | ||
- [Cmake](https://cmake.org/install/) | ||
|
||
## Contribution process overview | ||
1. Create your own fork of this project. | ||
2. Create a feature branch. | ||
3. Make your changes. | ||
4. Run the tests `make test`. | ||
5. Push changes to your fork/branch. | ||
6. Create pull request. | ||
7. Code review and automated testing. | ||
8. Merge into master. | ||
|
||
### 1. Fork | ||
1. Click the fork button up top. | ||
2. Clone your fork locally (Notice that git's `origin` reference will point to your forked repository). | ||
3. It is useful to have the upstream repository registered as well using: `git remote add upstream https://github.com/ollelauribostrom/cl-dotenv.git` and periodically fetch it using `git fetch upstream`. | ||
|
||
### 2. Create feature branch | ||
Create and switch to new feature branch: `git checkout -b {branch_name} upstream/master` | ||
(replace `{branch_name}` with a meaningful name that describes your feature or change). | ||
|
||
### 3. Make changes | ||
1. Now that you have a new branch you can edit/create/delete files. | ||
2. Use touch-up commits with main one (squash) -- the `git commit --amend` can be used for that. (You may use git force push after that). | ||
|
||
### 4. Run testing | ||
`make test`. | ||
`make coverage` | ||
|
||
### 5. Push changes to your fork/branch | ||
1. After lint and all tests pass, push the changes to your fork/branch on GitHub: `git push origin {branch_name}`. | ||
2. For force push, which will destroy previous commits on the server, use `--force` (or `-f`) option. | ||
|
||
### 6. Create pull request | ||
Create a pull request on GitHub for your feature branch. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
## Expected Behavior | ||
... | ||
|
||
## Actual Behavior | ||
... | ||
|
||
## Steps to Reproduce the Problem | ||
1. | ||
2. | ||
3. | ||
|
||
## Specifications | ||
- Version: | ||
- OS: | ||
- Lisp Installation: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
Associated Issue: #<issue number> | ||
|
||
Please get familiar with the contributing guide before submitting a PR: | ||
https://github.com/ollelauribostrom/cl-dotenv/blob/master/.github/CONTRIBUTING.md | ||
|
||
### Summary of Changes | ||
* change 1 | ||
* change 2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters