Skip to content

Commit

Permalink
🚨🚨🐛 Source Gitlab fix merge_request_commits stream (airbytehq#34548)
Browse files Browse the repository at this point in the history
  • Loading branch information
midavadim authored and jatinyadav-cc committed Feb 26, 2024
1 parent 37321ab commit 8af5655
Show file tree
Hide file tree
Showing 16 changed files with 248 additions and 248 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ acceptance_tests:
tests:
- config_path: "secrets/config.json"
backward_compatibility_tests_config:
disable_for_version: 1.8.4
disable_for_version: 3.0.0
basic_read:
tests:
- config_path: "secrets/config.json"
Expand All @@ -29,6 +29,11 @@ acceptance_tests:
jobs:
- name: "user"
bypass_reason: "User object contains local_time which will be different each time test is run"
projects:
- name: "updated_at"
bypass_reason: "value can be changed"
- name: "code_suggestions"
bypass_reason: "value can be changed"
- config_path: "secrets/config_with_ids.json"
timeout_seconds: 3600
empty_streams:
Expand All @@ -42,6 +47,11 @@ acceptance_tests:
jobs:
- name: "user"
bypass_reason: "User object contains local_time which will be different each time test is run"
projects:
- name: "updated_at"
bypass_reason: "value can be changed"
- name: "code_suggestions"
bypass_reason: "value can be changed"
- config_path: "secrets/config_oauth.json"
timeout_seconds: 3600
expect_records:
Expand All @@ -50,6 +60,11 @@ acceptance_tests:
jobs:
- name: "user"
bypass_reason: "User object contains local_time which will be different each time test is run"
projects:
- name: "updated_at"
bypass_reason: "value can be changed"
- name: "code_suggestions"
bypass_reason: "value can be changed"
incremental:
tests:
- config_path: "secrets/config_with_ids.json"
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

10 changes: 9 additions & 1 deletion airbyte-integrations/connectors/source-gitlab/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 5e6175e5-68e1-4c17-bff9-56103bbb0d80
dockerImageTag: 2.1.2
dockerImageTag: 3.0.0
dockerRepository: airbyte/source-gitlab
documentationUrl: https://docs.airbyte.com/integrations/sources/gitlab
githubIssueLabel: source-gitlab
Expand All @@ -29,6 +29,14 @@ data:
releaseStage: generally_available
releases:
breakingChanges:
3.0.0:
message:
In this release, merge_request_commits stream schema has been fixed so that it returns commits for each merge_request.
Users will need to refresh the source schema and reset merge_request_commits stream after upgrading.
upgradeDeadline: "2024-02-13"
scopedImpact:
- scopeType: stream
impactedScopes: ["merge_request_commits"]
2.0.0:
message:
In this release, several streams were updated to date-time field format, as declared in the Gitlab API.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,10 @@ def migrate(cls, args: List[str], source: SourceGitlab) -> None:


class MigrateGroups(MigrateStringToArray):

migrate_from_key: str = "groups"
migrate_to_key: str = "groups_list"


class MigrateProjects(MigrateStringToArray):

migrate_from_key: str = "projects"
migrate_to_key: str = "projects_list"
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,12 @@
},
"group_id": {
"type": ["null", "integer"]
},
"human_readable_end_date": {
"type": ["null", "string"]
},
"human_readable_timestamp": {
"type": ["null", "string"]
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,17 @@
}
}
}
},
"allowed_to_push": {
"type": ["null", "array"],
"items": {
"type": ["null", "object"],
"properties": {
"access_level": {
"type": ["null", "integer"]
}
}
}
}
}
},
Expand Down Expand Up @@ -74,6 +85,9 @@
"subgroup_creation_level": {
"type": ["null", "string"]
},
"enabled_git_access_protocol": {
"type": ["null", "string"]
},
"emails_disabled": {
"type": ["null", "boolean"]
},
Expand Down Expand Up @@ -153,6 +167,12 @@
},
"service_access_tokens_expiration_enforced": {
"type": ["null", "boolean"]
},
"lock_math_rendering_limits_enabled": {
"type": ["null", "boolean"]
},
"math_rendering_limits_enabled": {
"type": ["null", "boolean"]
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@
},
"id": {
"type": ["null", "integer"]
},
"locked": {
"type": ["null", "boolean"]
}
}
},
Expand All @@ -141,6 +144,12 @@
},
"username": {
"type": ["null", "string"]
},
"id": {
"type": ["null", "integer"]
},
"locked": {
"type": ["null", "boolean"]
}
}
},
Expand All @@ -164,6 +173,18 @@
},
"username": {
"type": ["null", "string"]
},
"human_readable_end_date": {
"type": ["null", "string"]
},
"human_readable_timestamp": {
"type": ["null", "string"]
},
"id": {
"type": ["null", "integer"]
},
"locked": {
"type": ["null", "boolean"]
}
}
},
Expand Down Expand Up @@ -251,6 +272,15 @@
},
"group_id": {
"type": ["null", "integer"]
},
"locked": {
"type": ["null", "boolean"]
},
"human_readable_end_date": {
"type": ["null", "string"]
},
"human_readable_timestamp": {
"type": ["null", "string"]
}
}
},
Expand Down
Loading

0 comments on commit 8af5655

Please sign in to comment.