TER-412 regenerate platform metadata on lint #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanaksinghal
force-pushed
the
kanak/TER-412
branch
from
8c1b03e
to
7e3ed32
Compare
|
Demo of the new no-op platform template: platform_usage.mp4 |
kanaksinghal
force-pushed
the
kanak/TER-412
branch
5 times, most recently
from
15f70a0
to
d65dbf2
Compare
change the behavior of lint command to always regenerate the platform metadata file (terrarium.yaml) on every lint command execution This implies that the manual changes in platform metadata file are not acceptable now. this also impacts the behavior of terrarium generate command such that it doesn't respect the manual changes in the platform metadata file This also impacts the example platform since it was not actually implementing the dependencies and it was only added to the metadata file to bypass the errors. Therefore this change also has updates the the `example/platform` such that now it implements each dependency in terraform and doesn't have manually adjusted metadata. Although the `example/platform` contains working mock implementation such that it can be used to test the t8 lint & generate command and can also run terraform plan and apply successfully but it'll generate random mock values for output instead of actually provisioning resources on cloud.
kanaksinghal
force-pushed
the
kanak/TER-412
branch
from
d65dbf2
to
ca92c86
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the behavior of lint command to always regenerate the platform metadata file (terrarium.yaml) on every lint command execution
This implies that the manual changes in platform metadata file are not acceptable now.
this also impacts the behavior of terrarium generate command such that it doesn't respect the manual changes in the platform metadata file
This also impacts the example platform since it was not actually implementing the dependencies and it was only added to the metadata file to bypass the errors.
Therefore this change also has updates the the
example/platformsuch that now it implements each dependency in terraform and doesn't have manually adjusted metadata.Although the
example/platformcontains working mock implementation such that it can be used to test the t8 lint & generate command and can also run terraform plan and apply successfully but it'll generate random mock values for output instead of actually provisioning resources on cloud.