Fix for HomeKit fan modes (issue #563) #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All credits to @kparmun for the fix ollo69#563 (comment)
|
It doesn't look really good alter an enum using in some cases lower case and in other upper case. If the problem is that HomeKit just support lower case options, the change should be implemented in the methods |
|
Hey @ollo69, hope it's better now. I'm not much of a coder. |
ollo69
reviewed
Feb 22, 2024
ollo69
requested changes
Feb 22, 2024
ollo69
reviewed
Feb 22, 2024
Co-authored-by: ollo69 <60491700+ollo69@users.noreply.github.com>
Co-authored-by: ollo69 <60491700+ollo69@users.noreply.github.com>
|
I committed the changes you recommended |
|
Not sure this is the right solution. Probably fan modes should be mapped with HA modes. |
ollo69
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All credits to @kparmun for the fix:
#563 (comment)