-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds sksl to reduce animations stutter #167
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,10 +4,10 @@ import 'package:flutter_riverpod/flutter_riverpod.dart'; | |
import 'package:layoutr/common_layout.dart'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorted the imports alphabetically ( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you know if this is linteable? It seems that it should, if flutter is complaining. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
import 'package:memo/application/constants/strings.dart' as strings; | ||
import 'package:memo/application/coordinator/routes_coordinator.dart'; | ||
import 'package:memo/application/pages/details/contributor_view.dart'; | ||
import 'package:memo/application/pages/details/details_providers.dart'; | ||
import 'package:memo/application/theme/theme_controller.dart'; | ||
import 'package:memo/application/view-models/details/collection_details_vm.dart'; | ||
import 'package:memo/application/pages/details/contributor_view.dart'; | ||
import 'package:memo/application/widgets/theme/hero_collection_card.dart'; | ||
import 'package:memo/application/widgets/theme/resources_list.dart'; | ||
import 'package:memo/application/widgets/theme/themed_container.dart'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the iOS minimum version was also bumped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why Flutter is automatically bumping this version to 9 every time I build the iOS app:
There's nothing about the minimum version change in the Breaking Changes guide, although they state in Build and release an iOS app
that the minimum supported version is iOS 9.0 (we also have deployment target set to 9.0 in the PBX)
TLDR: I don't know why Flutter automatically bumped, but the version 9 seems to be the correct one