Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post data for AJAX polyfill #33

Merged
merged 1 commit into from
Oct 29, 2017
Merged

Conversation

AdamPD
Copy link
Contributor

@AdamPD AdamPD commented Aug 15, 2017

I am not sure the reason; however, the AJAX polyfill was only pushing through the data parameter in the POST data if present. In my case, with long polling, this was leaving out messageId which seems to be fundamental in making long polling work.

This PR uses a lightweight URL parameter encoding to push the entire POST data.

This rectified the long polling functionality in my use case. I have not tested and am not aware of the following:

  1. This may or may not fix other instances where other POST data is relied upon for correct SignalR operation.
  2. Any regression that this my cause. I do find it peculiar that only the data parameter explicitly was being passed through so do have some concerns that this was for a valid reason.

@olofd olofd merged commit e3a8238 into olofd:master Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants