Libero Updates #398
Libero Updates #398
Conversation
|
Thank you for this. I have some questions about the changes and the libero backend in general. I did not write that one myself, and looking at it now I'm a bit confused about certain things. But I will start right away with pulling in your two first commits as I'm seeing the CI failures as well, that I believe these are aiming to fix. |
|
First two patches to fix CI are puled in now. Thanks for those! So, the first thing I wonder now is if there is a compelling reason to ever use |
Libero has two types of netlist constraints files that are synthesis only, so they didn't work with the existing setup. Adding specific filters for synthesis and place/route simplified the changes needed to the template.
Since Libero has a separate command for exporting files versus linking files, I added an export_files parameter to edatool to pass to the templates. I also made the global include paths relative to make it easier to move the project directory.
Always use `create_links` instead of `import_files` in the Libero project script to simplify the --no-export implementation.
paul-gatewood
force-pushed
the
Libero-No-Export
branch
from
d50236b
to
ffebb82
Compare
|
Of course, I'm glad I can contribute! That's a great point, I can't actually think of a use case for |
edalize/libero.py
Outdated
| @@ -186,19 +194,39 @@ def tcl_file_filter(self, f): | |||
| return file_types[_file_type] + f.name | |||
| return "" | |||
|
|
|||
| def constraint_file_filter(self, f, type="ALL"): | |||
| def syn_constraint_file_filter(self, f): | |||
| file_types = { | |||
There was a problem hiding this comment.
I don't really understand what this dict does. Could you explain?
There was a problem hiding this comment.
Oh, that dict used to supply the path to the constraints files when they were imported, but it's obsolete now that we're always linking. I'll take a stab at cleaning that up.
edalize/libero.py
Outdated
| "FDC": "constraint/", | ||
| "NDC": "constraint/", | ||
| } | ||
| _file_type = f.file_type.split("-")[0] |
There was a problem hiding this comment.
From what I can tell, it might just be used to convert file_types like vhdlSource-2008 to just vhdlSource. It seems like that pattern's used in a few other toolchains, like quartus.
There was a problem hiding this comment.
That would be my guess too, but since none of the potential matches contain dashes in the file type I suspect this whole function (as well as the other ones) can just be simplified to:
def pnr_constraint_file_filter(self, f):
if _file_type in ["PDC", "SDC", "FPPDC"]:
return f.name
edalize/libero.py
Outdated
| return f.name | ||
| return "" | ||
|
|
||
| def constraint_file_filter(self, f, type="ALL"): |
There was a problem hiding this comment.
Do we still need this function now that we have the syn and pnr versions?
There was a problem hiding this comment.
It was still used in one place for the timing constraints, but I replaced that with a simpler filter and removed this one.
|
Thanks. Happy to see the simplifications after dropping the export parts (and to answer your other question, it's technically FuseSoC that does the exporting). In general it looks good, but I made some comments where I think we can actually make further simplifcations. |
Since we're no longer importing the constraints files, we don't have to worry about converting the file names to point to the import paths, so the filters can be much simpler.
|
Many thanks for your contributions. Squashed and merged! |
Adds support for Libero netlist constraints and for --no-export with Libero. Also fixes some issues I was having with the PR checks.