-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate environment variable expansion in file names? #487
Comments
The main reason was for getting files from EDA tool installations, e.g. many Xilinx libs require simulating with But it's still problematic for the reason you cite and I see a couple of open issues
So, no. I don't think we can deprecate it yet but I think we could at least move the expansion to Edalize and treat all paths that needs expansions as absolute paths which means we will not copy them to the build tree |
Also, let's push this past the 1.12 release |
For the Xilinx use case (referring to e.g. But yeah, let's discuss this further after the 1.12 release. |
I don't think it's feasible to do that as tool installations can be decoupled from the design environment |
Since d8ece6b file names in filesets can contain environment variables, which are expanded during parsing. I'd like to better understand the use case for this feature, and potentially get rid of it.
Why I think this feature is a bad idea:
I wouldn't expect this feature to be widely used, since it is neither documented nor announced in the 1.8.2 release notes, where it appeared first (http://olofkindgren.blogspot.com/2018/06/fusesoc-182.html).
@olofk do you have an interesting use case for that, or can we deprecate it?
The text was updated successfully, but these errors were encountered: