update sass version #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshackles
requested changes
Mar 2, 2018
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "olo-gulp-helpers", | |||
| "version": "0.1.1", | |||
| "version": "0.1.2", | |||
There was a problem hiding this comment.
Only real nit would be that I think we should bump this to 0.2.0 since it bumps gulp-sass by a major version.
| @@ -18,7 +18,7 @@ | |||
| "gulp-if": "^2.0.0", | |||
| "gulp-plumber": "^1.1.0", | |||
| "gulp-rev": "^7.0.0", | |||
| "gulp-sass": "^2.2.0", | |||
| "gulp-sass": "3.1.0", | |||
There was a problem hiding this comment.
Intentional to lock this to a specific version instead of a range like the rest? Not necessarily opposed, just wondering if intentional
There was a problem hiding this comment.
locked because I won't be monitoring those builds as closely as Dashboard and wary of breaking changes making it into a minor release
happy to change it if you recommend
JonRossway
force-pushed
the
update-gulp-sass
branch
from
3ff3b84
to
1a1dab4
Compare
JonRossway
force-pushed
the
update-gulp-sass
branch
from
1a1dab4
to
2724c28
Compare
gshackles
approved these changes
Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update deps to allow olo-gulp-helpers to work with Node 5+
@gshackles I wasn't sure how we normally patch previous versions but this is based off olo-gulp-helpers-v0.1.1
The goal is to update our build agents to Node LTS but gulp-sass complains unless updated. This update would allow Ghost to use an older version of olo-gulp-helpers and still use Node LTS.