Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added v1 endpoints for pyFCm in new v1 package. #319

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

Subhrans
Copy link

Added v1 endpoints for pyFCm in new v1 package.
Added test for v1 baseapi

@olucurious
Copy link
Owner

Thank you so much for this @Subhrans 🙏🏾
Can you please look into the tests?

@Subhrans
Copy link
Author

Hi @olucurious ,
Yes, I will fix all the tests.
Thank you.

@pnambiar-signos
Copy link

Hi @olucurious @Subhrans , thanks for this! Do you think the v1 API for FCM will be implemented soon?

@Subhrans
Copy link
Author

Subhrans commented Jun 1, 2024

Hi @pnambiar-signos , @olucurious
I have pushed updated changes, but the pipeline not is running due to I am not able to understand whether the fixes are working or not.
Could you please approve?

@MauPoLom
Copy link

MauPoLom commented Jun 4, 2024

Praying for an response...

@olucurious olucurious changed the base branch from master to develop June 4, 2024 23:06
@Subhrans
Copy link
Author

Subhrans commented Jun 7, 2024

Hi @olucurious, I hope you doing well.
I have fixed this test issue, but the pipeline unable to run until you approve.
Could you please re-run the pipeline and merge it?

For immediate contact, you reach out to my LinkedIn profile (https://www.linkedin.com/in/subhransu-d/)

Thanks

@olucurious olucurious merged commit 51d7d62 into olucurious:develop Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants