Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#159616864 Improve validation logic #32

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

olusoladavid
Copy link
Owner

What does this PR do?

Improves the validation error responses of the API when a user or client makes a bad request

Description of Task to be completed

  • Add more descriptive error messages
  • Return all errors found in request instead of single error
  • Refactor controllers to have consistent return

How should this be manually tested?

What are the relevant pivotal tracker stories?

#159616864

- add more descriptive error messages
- return all errors found in request instead of single error
- refactor controllers to have consistent return

[Delivers #159616864]
@coveralls
Copy link

Pull Request Test Coverage Report for Build 108

  • 30 of 55 (54.55%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 80.702%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/utils/verifyToken.js 0 2 0.0%
server/controllers/userController.js 14 24 58.33%
server/controllers/entryController.js 16 29 55.17%
Totals Coverage Status
Change from base Build 106: -0.5%
Covered Lines: 142
Relevant Lines: 168

💛 - Coveralls

@olusoladavid olusoladavid merged commit 7f4b7c7 into develop Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants