Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#159752185 Fix http_headers_already_set error #37

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

olusoladavid
Copy link
Owner

What does this PR do?

Fix http_headers_already_sent Expressjs error due to double callbacks from async controllers

Description of Task to be completed

  • Refactor async controllers to use async/await for cleaner logic
  • Fix double callback error points

How should this be manually tested?

  • Review code changes to server/controllers
  • Pull branch into repo and run npm test

What are the relevant pivotal tracker stories?

#159752185

- alter users table with new column 'push_sub'

[Delivers #159742121]
- refactor controllers to use async/await for cleaner logic
- fix double callbacks

[Delivers #159752185]
@coveralls
Copy link

Pull Request Test Coverage Report for Build 123

  • 63 of 69 (91.3%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+10.5%) to 91.892%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/index.js 3 4 75.0%
server/controllers/userController.js 24 25 96.0%
server/controllers/entryController.js 32 36 88.89%
Totals Coverage Status
Change from base Build 122: 10.5%
Covered Lines: 142
Relevant Lines: 149

💛 - Coveralls

@olusoladavid olusoladavid merged commit 17e377f into develop Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants