Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#159867093 Make minor changes to API output and tests #39

Merged
merged 1 commit into from
Aug 18, 2018

Conversation

olusoladavid
Copy link
Owner

What does this PR do?

Makes minor changes to the output of some API endpoints

Description of Task to be completed

  • sort entries by date in descending order by default
  • create tables if not exists before tests
  • change email_reminder to reminder_set
  • change all sendStatus to status.json to ensure json type response

How should this be manually tested?

  • Pull branch into local repo and run npm test
  • Use Postman to inspect the outputs of /entries and /profile endpoints

What are the relevant pivotal tracker stories?

#159867093

- sort entries by date in descending order by default
- create tables if not exists before tests
- change email_reminder to reminder_set
- change all sendStatus to status.json to ensure json type response

[Delivers #159867093]
@coveralls
Copy link

Pull Request Test Coverage Report for Build 132

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 130: 0.0%
Covered Lines: 162
Relevant Lines: 162

💛 - Coveralls

@olusoladavid olusoladavid merged commit ffe61cb into develop Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants