Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#159328959 Add daily diary update reminder feature #41

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

olusoladavid
Copy link
Owner

What does this PR do?

Completes a new feature which enables users to receive daily reminders to update their diary via push notifications

Description of Task to be completed

  • Add tests for feature
  • Implement feature to be able to run in stand-alone mode

How should this be manually tested?

  • Pull branch into local machine
  • Authenticate a push enabled client at https://olusoladavid.github.io/my-diary-client and subscribe for push notifications on the user profile
  • cd my-diary
  • Run node server/workers/sendNotifications.js with a valid push subscription
  • Receive notification in client

What are the relevant pivotal tracker stories?

#159328959

- add tests for feature
- implement feature to be able to run stand-alone

[Delivers #159328959]
@olusoladavid olusoladavid merged commit 1d7af90 into develop Aug 24, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 138

  • 18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 136: 0.0%
Covered Lines: 180
Relevant Lines: 180

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants