Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach build to GitHub releases #3

Open
kumy opened this issue Jan 3, 2022 · 12 comments · May be fixed by #6
Open

Attach build to GitHub releases #3

kumy opened this issue Jan 3, 2022 · 12 comments · May be fixed by #6

Comments

@kumy
Copy link

kumy commented Jan 3, 2022

As said in #2 (comment), it would be awesome to have already built packages signed by your own key attached to the GitHub releases. (it would also be nice to have the download apk link on your website)

This would help:

Thanks a lot!

Edit: you can find my own automated builds at https://github.com/kumy/olvid-android/releases

@kumy kumy linked a pull request Jan 3, 2022 that will close this issue
kumy added a commit to kumy/olvid-android that referenced this issue Sep 15, 2022
kumy added a commit to kumy/olvid-android that referenced this issue Oct 28, 2022
kumy added a commit to kumy/olvid-android that referenced this issue Jan 26, 2023
kumy added a commit to kumy/olvid-android that referenced this issue Feb 7, 2023
@kumy
Copy link
Author

kumy commented Feb 7, 2023

geokrety-bot pushed a commit to kumy/olvid-android that referenced this issue May 15, 2023
@Morse6690
Copy link

Morse6690 commented May 29, 2023

I just saw your response to the fdroid build request. Thanks for the update. Seeing that that won't happen at least in the short term, is adding an apk file to the releases section for each new release a possibility?

@finiasz
Copy link
Contributor

finiasz commented May 29, 2023

Hello @Morse6690, we know several users would be interested in an official "non store" APK but we do not want to incentivize them to install APKs signed by a random key. Also, it would be easy for anyone impersonating the github website to distribute a malicious APK.

At least, F-Droid and Google Play can check the APK is properly signed.

@Morse6690
Copy link

I can understand your concerns with this. Having said that there is a use case for this, hence apps like signal make sure they provide an apk that can be downloaded from outside the play store.
People who can't access the play store can either use a dodgy third party website like apkpure or similar or they just don't install it. I would think these third party app sites have far greater risk to an end user than an app placed by the developer on github, or hosted on your website in a non obvious location, similar to what signal has done.
Of course these users cannot use the payment features of the play store to pay for the extras features.
However I believe that the users who may be interested enough to download via this method are savvy enough understand the dangers. The average person will only ever use the play store.

geokrety-bot pushed a commit to kumy/olvid-android that referenced this issue Jul 15, 2023
geokrety-bot pushed a commit to kumy/olvid-android that referenced this issue Aug 1, 2023
kumy added a commit to kumy/olvid-android that referenced this issue Oct 17, 2023
@kumy
Copy link
Author

kumy commented Oct 17, 2023

Build ready v1.0_216-kumy1

kumy added a commit to kumy/olvid-android that referenced this issue Nov 2, 2023
@Morse6690
Copy link

Is it possible to do something similar to signal?
They provide an apk that can be downloaded directly from their own website. Users are prompted when a new update is available which can be installed by hitting "ok" on the "new update available" notification.

@finiasz
Copy link
Contributor

finiasz commented Nov 29, 2023

Just a quick note here: we are now providing an APK for download directly from our website. This APK is a universal APK signed with the same keys as the version available on Google Play. This means push notifications can work for users with Google Services installed. We do not provide an APK for the "no google" flavor of the app.

https://olvid.io/download/

@kumy
Copy link
Author

kumy commented Nov 29, 2023

That's a great step forward, thanks. What are the reason behind the "We do not provide an APK for the "no google" flavor of the app."?

@Morse6690
Copy link

Making sure the "use foreground service" option is turned on should mean that notifications will be received whether the device has Google play services installed or not?
Is that right?

@finiasz
Copy link
Contributor

finiasz commented Nov 30, 2023

Hi @Morse6690 , the "use foreground service" is not exactly for this. We have a "maintain a permanent websocket connection" option that can replace Google push notifications. The "use foreground service" is just there to prevent the app from being killed in the background by the system, but it's not that useful. The websocket connection will also use a foreground service to keep the app alive.

Keep in mind that the permanent websocket may drain the battery (a few percents in one day), so if you have too many apps doing the same as us, this might become an issue :)

@Morse6690
Copy link

That's right... Forgot that other setting. I have used those two settings on my Graphenos device for 18 months. The battery drain was pretty minimal, and never had a problem receiving messages.

kumy added a commit to kumy/olvid-android that referenced this issue Dec 4, 2023
@kumy
Copy link
Author

kumy commented Dec 4, 2023

For those like me using the "no google" version, I'll continue to build the releases on my side.
Here is v1.3_220-kumy1

kumy added a commit to kumy/olvid-android that referenced this issue Dec 9, 2023
kumy added a commit to kumy/olvid-android that referenced this issue Jan 31, 2024
kumy added a commit to kumy/olvid-android that referenced this issue Mar 4, 2024
kumy added a commit to kumy/olvid-android that referenced this issue Mar 14, 2024
kumy added a commit to kumy/olvid-android that referenced this issue Mar 20, 2024
kumy added a commit to kumy/olvid-android that referenced this issue May 1, 2024
kumy added a commit to kumy/olvid-android that referenced this issue May 2, 2024
github-actions bot pushed a commit to kumy/olvid-android that referenced this issue May 2, 2024
github-actions bot pushed a commit to kumy/olvid-android that referenced this issue May 2, 2024
github-actions bot pushed a commit to kumy/olvid-android that referenced this issue May 2, 2024
github-actions bot pushed a commit to kumy/olvid-android that referenced this issue May 2, 2024
github-actions bot pushed a commit to kumy/olvid-android that referenced this issue May 2, 2024
github-actions bot pushed a commit to kumy/olvid-android that referenced this issue May 2, 2024
github-actions bot pushed a commit to kumy/olvid-android that referenced this issue May 2, 2024
github-actions bot pushed a commit to kumy/olvid-android that referenced this issue May 2, 2024
github-actions bot pushed a commit to kumy/olvid-android that referenced this issue May 2, 2024
github-actions bot pushed a commit to kumy/olvid-android that referenced this issue May 3, 2024
github-actions bot pushed a commit to kumy/olvid-android that referenced this issue May 6, 2024
github-actions bot pushed a commit to kumy/olvid-android that referenced this issue Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants