Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.8 support #29

Closed
dmvieira opened this issue Jun 9, 2020 · 2 comments · Fixed by #35
Closed

Python 3.8 support #29

dmvieira opened this issue Jun 9, 2020 · 2 comments · Fixed by #35
Labels
enhancement New feature or request

Comments

@dmvieira
Copy link
Contributor

dmvieira commented Jun 9, 2020

Nowadays python 3.8 tests are broken because of json logger: https://travis-ci.com/github/olxbr/BarterDude/jobs/346357213
@dmvieira dmvieira added the enhancement New feature or request label Jun 9, 2020
@tirkarthi
Copy link

Seems to be fixed with madzak/python-json-logger@35a8ca2

@dmvieira
Copy link
Contributor Author

I'll try an PR here with it. Thank you @tirkarthi !

dmvieira added a commit that referenced this issue Oct 21, 2020
@dmvieira
Now supporting python 3.8 fixes #29
68a65eb
@dmvieira dmvieira mentioned this issue Oct 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Now supporting python 3.8 olxbr/BarterDude
2 participants
@dmvieira @tirkarthi