Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing api to force a label if not set #28

Merged
merged 4 commits into from
Jun 10, 2020
Merged

Changing api to force a label if not set #28

merged 4 commits into from
Jun 10, 2020

Conversation

dmvieira
Copy link
Contributor

@dmvieira dmvieira commented Jun 8, 2020

Forcing label to application name, added pytest to stop log errors and fixed travis coverage for python 3.7

@dmvieira
Changing api to force a label if not set
1b57b59 
Forcing label to application name, added pytest to stop log errors and fixed travis coverage for python 3.7
@dmvieira dmvieira requested a review from gligneul June 8, 2020 23:56
dmvieira
dmvieira commented Jun 9, 2020
View reviewed changes
barterdude/hooks/metrics/prometheus/__init__.py Show resolved Hide resolved
barterdude/hooks/metrics/prometheus/__init__.py Outdated Show resolved Hide resolved
barterdude/hooks/metrics/prometheus/definitions.py Show resolved Hide resolved
requirements/requirements_test.txt Show resolved Hide resolved
tests_integration/test_barterdude.py Outdated Show resolved Hide resolved
@dmvieira dmvieira merged commit b750678 into master Jun 10, 2020
@dmvieira dmvieira deleted the fix/prometheus-with-no-labels branch June 10, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gligneul gligneul gligneul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmvieira @gligneul