feat(perf): manually install and configure libvips #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)-manually-install-and-configure-libvips # Conflicts: # Cargo.toml
bassco
requested changes
Nov 24, 2023
bassco
changed the title
…y conventional commits
bassco
requested changes
Nov 28, 2023
Dockerfile
Outdated
| libheif=1.16.2-r0 \ | ||
| libde265=1.0.12-r0 | ||
|
|
||
| ENV GI_TYPELIB_PATH=/usr/lib/girepository-1.0 |
There was a problem hiding this comment.
Can you move this ENV statement to under the FROM - it will help with layer caching
Dockerfile
Outdated
Comment on lines
47
to
61
| libgsf=1.14.50-r1 \ | ||
| glib=2.76.4-r0 \ | ||
| expat=2.5.0-r1 \ | ||
| tiff=4.5.1-r0 \ | ||
| libjpeg-turbo=2.1.5.1-r3 \ | ||
| libexif=0.6.24-r1 \ | ||
| giflib=5.2.1-r4 \ | ||
| librsvg=2.56.3-r0 \ | ||
| lcms2=2.15-r2 \ | ||
| libpng=1.6.39-r3 \ | ||
| orc=0.4.34-r0 \ | ||
| libwebp=1.3.2-r0 \ | ||
| libimagequant=4.2.0-r0 \ | ||
| libheif=1.16.2-r0 \ | ||
| libde265=1.0.12-r0 |
There was a problem hiding this comment.
Can you sort this list - makes it easier to read and find a package that was added/removed.
|
This PR is included in version 1.6.0 🎉 |
4 similar comments
|
This PR is included in version 1.6.0 🎉 |
|
This PR is included in version 1.6.0 🎉 |
|
This PR is included in version 1.6.0 🎉 |
|
This PR is included in version 1.6.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need this?
In order to keep the good performance of Dali, we must manually install and configure libvips inside the Docker image. Previously we've tried to use the community built bundles (i.e. vips and vips-heif) and the performance significantly degraded.
What does this change?