-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perf): manually install and configure libvips #59
feat(perf): manually install and configure libvips #59
Conversation
…)-manually-install-and-configure-libvips # Conflicts: # Cargo.toml
…y conventional commits
Dockerfile
Outdated
libheif=1.16.2-r0 \ | ||
libde265=1.0.12-r0 | ||
|
||
ENV GI_TYPELIB_PATH=/usr/lib/girepository-1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this ENV
statement to under the FROM
- it will help with layer caching
Dockerfile
Outdated
libgsf=1.14.50-r1 \ | ||
glib=2.76.4-r0 \ | ||
expat=2.5.0-r1 \ | ||
tiff=4.5.1-r0 \ | ||
libjpeg-turbo=2.1.5.1-r3 \ | ||
libexif=0.6.24-r1 \ | ||
giflib=5.2.1-r4 \ | ||
librsvg=2.56.3-r0 \ | ||
lcms2=2.15-r2 \ | ||
libpng=1.6.39-r3 \ | ||
orc=0.4.34-r0 \ | ||
libwebp=1.3.2-r0 \ | ||
libimagequant=4.2.0-r0 \ | ||
libheif=1.16.2-r0 \ | ||
libde265=1.0.12-r0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you sort this list - makes it easier to read and find a package that was added/removed.
This PR is included in version 1.6.0 🎉 |
4 similar comments
This PR is included in version 1.6.0 🎉 |
This PR is included in version 1.6.0 🎉 |
This PR is included in version 1.6.0 🎉 |
This PR is included in version 1.6.0 🎉 |
Why do we need this?
In order to keep the good performance of Dali, we must manually install and configure libvips inside the Docker image. Previously we've tried to use the community built bundles (i.e. vips and vips-heif) and the performance significantly degraded.
What does this change?