Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades to vips v8.13.3 and bindgen 0.63.0 #28

Merged
merged 3 commits into from
Jan 4, 2023

Conversation

BogdanVidrean
Copy link
Collaborator

Just like the name of the PR suggests, it upgrades this crate to libvips 8.13.3 and generates the bindings using bindgen 0.63.0.

@BogdanVidrean BogdanVidrean self-assigned this Jan 4, 2023
Copy link
Collaborator

@bassco bassco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the following unreachable code.

warning: unreachable expression
   --> src/lib.rs:114:13
    |
113 |             bindings::vips_error_exit(c_str_error.as_ptr());
    |             ----------------------------------------------- any code following this expression is unreachable
114 |             Ok(())
    |             ^^^^^^ unreachable expression
    |
    = note: `#[warn(unreachable_code)]` on by default```

@bassco bassco merged commit 8776c4c into master Jan 4, 2023
@bassco bassco mentioned this pull request Jan 4, 2023
@bassco bassco deleted the Upgrades_to_vips_v8.13.3_and_bindgen_0.63.0 branch January 23, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants