Add gifsave bindings. #31
Conversation
|
Thanks for the contribution. Can you let us know how you created these bindings. i.e. was it an additional dev dependency added to the cli, or did you manually make the changes? In this way, we can add the additional context for future upgrades. |
|
@bigfarts - can you help us with the config you used to create these binds - they will be lost in future upgrades if we cannot add the generation to the current workflow |
|
Oops, I didn't realize there was a generator. It looks like I just had to install cgif-dev to make this work. |
|
Hmm, it looks like I ended up generating aarch64 bindings. I don't have an x86_64 machine to generate x86_64 bindings unfortunately, you might need to generate the bindings on your side for the right architecture. Sorry about that! |
Do you think the removal of the The attached files in the PR LGTM. i.e. I don't see any architecture specifics within them. |
|
My computer is aarch64 and it looks like it installed the aarch64 Docker image. In the bindings.rs diff (hidden by default) there's a bunch of aarch64-specific symbols it decided to put in there: https://github.com/olxgroup-oss/libvips-rust-bindings/pull/31/files#diff-c030113407a164cbd1ad3500c613f59abd4346ba13ee5b653c56f393c937b0a8R4499-R4504 |
|
good catch! ok, can I propose that I take your changes and generate the code into a separate PR? I'll be able to get @BogdanVidrean to review and merge tomorrow and then we can publish a patch release to crates? |
|
hold on, let me see if I can push some changes to this branch - it wasn't obvious initially, but I thinkI have found a way to do this. |
The bindings unfortunately aren't generated because my computer has a funny architecture.
|
I've removed the bindings generation from this PR and just edited the Dockerfile. Thanks! |
|
I appreciate your help @bigfarts and thanks for the contribution. I'll setup the PR for the new version |
No description provided.