Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clerk #50

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Clerk #50

wants to merge 6 commits into from

Conversation

ehannes
Copy link
Contributor

@ehannes ehannes commented Nov 4, 2022

Adds oma-clerk

To be able to test clerk with set clerk id, you need to run port 4000.
You also need to connect to localhost rather than 127.0.0.1. We should
fix that...

Also, changing to live-server instead of http-server since that server
has live reload feature.
@ehannes ehannes requested a review from d-Pixie November 4, 2022 06:46
@ehannes
Copy link
Contributor Author

ehannes commented Nov 7, 2022

How do we prevent multiple sends? We currently prevent someone from posting while already posting. But when we get a success or failure, we need to "reset" the whole component, clean the form and run the ClientLibrary again. Is there a smart way to do that?

},
"dependencies": {
"haunted": "^4.7.0"
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider depending on Clerk here instead.

@@ -0,0 +1,123 @@
import { component, html, useState } from 'haunted'

import ClientLibrary from './client-library.js'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import 'clerk/client-library'

components/clerk/src/index.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant