Dash to underscore replacing leads to duplicate entries in social_auth_by_name_backends

[mikek]

The context_processors.social_auth_by_name_backends adds a new item with dash replaced by undersocre for the backends which the authenticated user has associated with his account.

So after authenticating the social_auth.items|pprint in template reveals duplicate entries like:
[(u'google_oauth2', <UserSocialAuth: bot44cafe - Google-Oauth2>), ('google-oauth2', None), ('facebook', None)].

This makes hard to iterate over them constructing URLs with backend names, etc. Is this replacement a must-have? Could we at least make it consistent by removing items (with None values) replaced in this process? (This does not solve constructing urls though.)

[mikek]

Even a simple workaround like this would not work if user has not associated account with a dash in backend name. The list will not include the backend with a dash because it is replaced only for associated accounts.

<h3>Connect more accounts (to be able to log in with any of them)</h3>
<ul>
    {% for backend, user_sa in social_auth.items %}
        {% if not user_sa and not '-' in backend %}
            <li><a href="{% url 'socialauth_begin' backend %}">{{ backend }}</a></li>
        {% endif %}
    {% endfor %}
</ul>

[omab]

@mikek, I've pushed a fix for this issue, now all backends have - replaced with _ and no more duplicates now. The replacement is done to allow access by attribute in templates, so you can do social_auth.google_oauth2 if needed.

[mikek]

While we can get disconnect URLs regardless of the backend 'key':

{% for backend, user_sa in social_auth.items %}
    {% if user_sa %}
        {% url 'socialauth_disconnect_individual' user_sa.provider user_sa.id %}
    {% endif %}
{% endfor %}

'socialauth_begin' URLs for backends with dashes are broken now:

{% for backend, user_sa in social_auth.items %}
    {% url 'socialauth_begin' backend %}
{% endfor %}

will produce 'underscored' URLs.

Any other way to iterate over all enabled backends to connect and disconnect accounts?

[omab]

@mikek, my bad, I've removed the dash replacement with underscore, the dict won't be accessible using dot notation, but seems that nobody is using it like that or an issue would be raised already.

[mikek]

Thanks, this simple approach should add no controversy!