Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch email when sign up with github #755

Closed
shmygol opened this issue Aug 29, 2013 · 3 comments
Closed

Fetch email when sign up with github #755

shmygol opened this issue Aug 29, 2013 · 3 comments

Comments

@shmygol
Copy link
Contributor

shmygol commented Aug 29, 2013

Email is mentioned in the code (file backends/contrib/github.py) but doesn't really work

     details = {'username': response.get('login'),
                'email': response.get('email') or ''}
shmygol added a commit to shmygol/django-social-auth that referenced this issue Aug 29, 2013
omab added a commit that referenced this issue Aug 29, 2013
…n-up-with-github

issue #755: added fetching email functionality to github backend.
@omab omab closed this as completed Aug 29, 2013
@shmygol
Copy link
Contributor Author

shmygol commented Aug 30, 2013

Hi Matías. Can you tell how soon will it be in the stable version available by pip?

@omab
Copy link
Owner

omab commented Aug 30, 2013

@trilliput, I've released v0.7.26 to pypi. I guess you already know this, but to make your /emails endpoint work you need the proper scope (user or user:email) this grants you access to the private email addresses of the user, otherwise the app tries to get the public email address (the .get('email') or '' in the code).

@shmygol
Copy link
Contributor Author

shmygol commented Aug 30, 2013

@omab Sure. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants