Make get_username in pipeline a functor. #253
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to factor out the check for the existence of a username, so that
it is easier to override and customize in subclasses.
One of the reasons that this is needed is that django-userena considers two usernames that differ only in case to be the same, while the default behavior of django-social-auth does not. As a result, userena will fail with a MultipleObjectsReturned exception.
With this change, developers will only have to subclass GetPassword and override just the username_exists method.