SocialAuthBackend only needs to authenticated #475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempting to get this library to work with a permissions backend it kept failing because SociaAuthBackend was inheriting from the django.contrib.auth.backends.ModelBackend. The default Django AuthBackend assumes SQL. Since this application does both SQL and Mongo it should not make the same assumptions.
The SocialAuthBackend only needs to implement authenticate, since it only does authentication. Since it defines authenticate as a method, it's fine to inherit from object rather than the django model auth backend.
I've tested this change against a few backends for SQL and Mongo and not had any issues. Since tests are manual though, I recommend doing some as well.
for reference
https://docs.djangoproject.com/en/dev/topics/auth/#authentication-backends