Corrected calculation of UserSocialAuthMixin.expiration_datetime #656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected calculation of "now timestamp" in utc.
datetime.now()
returns a datetime in local time zone so by doing now.replace(tzinfo=utc) you are adding/removing time (depending on your configured local timezone)I changed it to use
now_timestamp
because it is calculated withtime.mktime
and it takes into account time zones.If you were if the side of the word where "UTC offset > than provider session time" the function
UserSocialAuthMixin.expiration_datetime
returned a negative time that forced the expiration of the django session.