Fix the google white listed emails validation code #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are configured and an email address not in the whitelisted list is given. Also make the validate_whitelists function fail closed. Signed-off-by: David Black <dblack@atlassian.com>
… a domain is in the allowed white-list set of emails and domains respectively. Signed-off-by: David Black <dblack@atlassian.com>
|
@omab ping! |
omab
added a commit
that referenced
this pull request
Aug 20, 2013
…_validation_code Fix the google white listed emails validation code
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The google white-list email validation code previously had a security issue where by a django application which was configured to only accept a list of emails would 'fail open' because no error was raised when the email address to validate was not in the list of allowed emails and no domain was configured!