Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy fixes #18

Merged
merged 2 commits into from Jul 15, 2013
Merged

SQLAlchemy fixes #18

merged 2 commits into from Jul 15, 2013

Conversation

Flyflo
Copy link
Contributor

@Flyflo Flyflo commented Jul 15, 2013

This pull request fixes two bugs I encountered when using the SQLAlchemy orm.

  1. The disconnect method doesn't commit the session after removing the association, preventing the association from being really deleted.
  2. Calling the remove method of a SQLAlchemyAssociationMixin raise an InvalidRequestError: Could not evaluate current criteria in Python. Specify 'fetch' or False for the synchronize_session parameter.

omab added a commit that referenced this pull request Jul 15, 2013
@omab omab merged commit 716e57c into omab:master Jul 15, 2013
@omab
Copy link
Owner

omab commented Jul 15, 2013

Thanks!

@Flyflo Flyflo deleted the sqlalchemy_fixes branch July 15, 2013 16:05
jenkins-ks pushed a commit to nttks/python-social-auth that referenced this pull request Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants