Added support for NGPVAN ActionID OpenID #750
Conversation
| @@ -24,7 +24,7 @@ class User(BaseModel): | |||
| cache = {} | |||
| _is_active = True | |||
|
|
|||
| def __init__(self, username, email=None): | |||
| def __init__(self, username, email=None, **extra_user_fields): | |||
There was a problem hiding this comment.
Added this here to better mimic what Django allows during the create_user step and thus better test USER_FIELDS
|
@omab let me know if you have any concerns here. I need to incorporate this into a larger open source project and would prefer to simply have |
|
@omab squashed this commit, but the addition of naver upstream causes a merge conflict (two "n" backends) you'll need to fix FYI, this is currently live at https://public.ofaconnect.com/ if you want to check it out. It'd be great to have this merged in so that I can change the requirements.txt file in https://github.com/ofa/connect to reference the pypi entry instead of a github fork. |
|
Took a couple months, but it's finally merged. Thanks! |
|
Awesome! @omab Can you push this to PyPI? Thanks |
Put together a full implementation of the NGPVAN ActionID OpenID backend.
They'll offer OpenID Connect soon, but supporting their version of OpenID connect could involve some significant refactoring of the OpenID Connect implementation already in
python-social-auth, so starting out with the standard OpenID 1.1 implementation would probably be a good first step.Let me know what you think.
Thanks!