Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter fixes for SAML to support Py2.6 #783

Merged
merged 1 commit into from
Dec 17, 2015
Merged

Conversation

matburt
Copy link
Contributor

@matburt matburt commented Nov 11, 2015

This fix allows the SAML Backend to support Python 2.6

@chrismeyersfsu
Copy link

👍 works with py2.6 for me.

@tkajtoch
Copy link

Clean commit.
Python 2.6 requires the replacement_field to be filled by the field_name.

Docs: https://docs.python.org/2.6/library/string.html#format-string-syntax

@matburt
Copy link
Contributor Author

matburt commented Dec 17, 2015

You can use {0} for positional arguments though (which is what is used here)... you just can't use the empty variant {}

@tkajtoch
Copy link

@matburt I know. My comment is just some kind of note for @omab to accept this PR quickly :-)

@matburt
Copy link
Contributor Author

matburt commented Dec 17, 2015

ah, gotcha!

On Thu, Dec 17, 2015 at 5:01 AM, Tomasz Kajtoch notifications@github.com
wrote:

@matburt https://github.com/matburt I know. My comment is just some
kind of note for @omab https://github.com/omab to accept this PR
quickly :-)


Reply to this email directly or view it on GitHub
#783 (comment)
.

omab added a commit that referenced this pull request Dec 17, 2015
Formatter fixes for SAML to support Py2.6
@omab omab merged commit 43b72de into omab:master Dec 17, 2015
@omab
Copy link
Owner

omab commented Dec 17, 2015

Sorry for the delay.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants