Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAML: raise AuthMissingParameter if idp param missing #821

Merged
merged 1 commit into from
Mar 27, 2016
Merged

SAML: raise AuthMissingParameter if idp param missing #821

merged 1 commit into from
Mar 27, 2016

Conversation

omarkhan
Copy link
Contributor

The SAML login handler fails with a KeyError if the idp query param is not given, which leads to a 500 response. Raise AuthMissingParameter instead.

@omarkhan
SAML: raise AuthMissingParameter if idp param missing
ca3a71f 
The SAML login handler fails with a KeyError if the idp query param is
not given, which leads to a 500 response. Raise AuthMissingParameter
instead.
@omarkhan omarkhan mentioned this pull request Jan 15, 2016
Merged
@omab omab merged commit 9724cf8 into omab:master Mar 27, 2016
@omab
Copy link
Owner

omab commented Mar 27, 2016

Thanks!

@mattdrayer mattdrayer mentioned this pull request Sep 15, 2016
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omarkhan @omab