Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings variable 'PIPELINE' to 'SOCIAL_AUTH_PIPELINE' #888

Closed
wants to merge 1 commit into from

Conversation

paulsoh
Copy link

@paulsoh paulsoh commented Apr 7, 2016

Changed variable name to be more specific.
'PIPELINE' variable is also a settings variable used in django-pipeline, which causes an error when used together. #838

Changed variable name to be more specific
:'PIPELINE' variable is also a settings variable used in django-pipeline, which leads to error when used together.
@webjunkie
Copy link
Contributor

You can already just use SOCIAL_AUTH_PIPELINE and it should work...

@paulsoh
Copy link
Author

paulsoh commented Apr 29, 2016

@webjunkie Thanks for proving my point.

The default namespace PSA uses is PIPELINE which causes an error when used with django-pipeline, (django-pipeline also uses PIPELINE) and as you said if you change it to SOCIAL_AUTH_PIPELINE for PSA there is no conflict between these two packages.

Thats the reason for this PR, I changed the default PIPELINE to SOCIAL_AUTH_PIPELINE.

@webjunkie
Copy link
Contributor

webjunkie commented Apr 29, 2016

@paulsoh You did not get me right. There is no use for this PR as the default is already SOCIAL_AUTH_PIPELINE. The self.setting() method in the same lines that you want to be changed automatically prefixes everything with SOCIAL_AUTH_ and at least for me, I just use SOCIAL_AUTH_WHATEVER in my settings and it works without conflicts.

@omab
Copy link
Owner

omab commented Jun 5, 2016

python-social-auth will try several setting names in the following order:

  • SOCIAL_AUTH_<BACKEND_NAME>_PIPELINE
  • SOCIAL_AUTH_PIPELINE
  • PIPELINE

The utility setting_name in utils.py adds the setting prefix SOCIAL_AUTH_ to the names.

@omab omab closed this Jun 5, 2016
@dobestan
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants