Added transaction support around user creation to prevent race conditions #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsongee
force-pushed
the
feature/user_create_atomic1
branch
from
8c363d6
to
8e56b08
Compare
carsongee
force-pushed
the
feature/user_create_atomic1
branch
from
8e56b08
to
c1d95f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the same change made in #770 but this adds transaction support around creating the user object as well. The reasoning here is a bit different than #770 as this is just intended to prevent request failures in scenarios where a client is logging in for the first time simultaneously via multiple parallel API calls using token authentication and creating 500 responses as a result of the user being created in a different fork.