Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-2.6 support #73

Closed
jlaska opened this issue Feb 23, 2015 · 6 comments
Closed

python-2.6 support #73

jlaska opened this issue Feb 23, 2015 · 6 comments

Comments

@jlaska
Copy link
Contributor

jlaska commented Feb 23, 2015

Is there interest in extending fauxfactory to work with python-2.6?

The main blocker I'm aware of is the existing use of sys.version_info.major. On python-2.6, you'd need to use sys.version_info[0]. If there is interest, I can send over a pull request.

@omaciel
Copy link
Owner

omaciel commented Feb 23, 2015

No reason why we wouldn't support it specially if it comes with a PR :)

@jlaska
Copy link
Contributor Author

jlaska commented Feb 23, 2015

While I'm at it, any objections to using pytest to run the existing unittests? The reason being that the unittest dependencies are not python-2.6 friendly. I'm finding it far simpler to just migrate tests over to pytest.

@Ichimonji10
Copy link
Contributor

@jlaska unittest is part of the standard library in Python 2.6. How could its dependencies be unfriendly to Python 2.6? Can you enumerate what those problematic dependencies are?

@jlaska
Copy link
Contributor Author

jlaska commented Feb 23, 2015

I believe discover is 2.7+.

Many new features were added to unittest in Python 2.7, including test
discovery. unittest2 allows you to use these features with earlier versions
of Python.

You'd need to migrate to unittest2. I started down that path, but just had better luck using pytest as the runner+collector.

@jlaska
Copy link
Contributor Author

jlaska commented Feb 23, 2015

I've submitted #74 for review. We can close this card and track the PR if you prefer.

@hugovk
Copy link

hugovk commented Oct 16, 2017

#74 is merged, can this be closed?

@omaciel omaciel closed this as completed Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants