Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't install tests into the binary distribution #93

Merged
merged 1 commit into from Feb 19, 2018
Merged

don't install tests into the binary distribution #93

merged 1 commit into from Feb 19, 2018

Conversation

evgeni
Copy link
Contributor

@evgeni evgeni commented Feb 19, 2018

this tries to install a "tests" python package, which we don't own.
at the same time, also exclude docs and contrib as done in the PyPA
sample project [1]

[1] https://github.com/pypa/sampleproject/blob/master/setup.py

this tries to install a "tests" python package, which we don't own.
at the same time, also exclude docs and contrib as done in the PyPA
sample project [1]

[1] https://github.com/pypa/sampleproject/blob/master/setup.py
@codecov
Copy link

codecov bot commented Feb 19, 2018

Codecov Report

Merging #93 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #93   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         452    452           
=====================================
  Hits          452    452

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177e8c8...7f92dde. Read the comment docs.

@omaciel
Copy link
Owner

omaciel commented Feb 19, 2018

ack

@omaciel omaciel merged commit b291873 into omaciel:master Feb 19, 2018
@omaciel
Copy link
Owner

omaciel commented Feb 19, 2018

Thank you @evgeni

@evgeni
Copy link
Contributor Author

evgeni commented Feb 19, 2018

Thanks @omaciel, will you do a release to PyPI too? :)

@omaciel
Copy link
Owner

omaciel commented Feb 19, 2018

@evgeni I can but it would only support Python 3. Is that cool with what you need?

@evgeni
Copy link
Contributor Author

evgeni commented Feb 19, 2018

Nope :(
Need it for nailgun, which we use inside ansible, which is not really py3 ready yet.

@omaciel
Copy link
Owner

omaciel commented Feb 19, 2018

@evgeni one way would be to create a new version off the python2 branch...

@evgeni evgeni deleted the dont-install-tests branch February 20, 2018 08:47
@evgeni
Copy link
Contributor Author

evgeni commented Feb 20, 2018

@omaciel if that's not too much ask, that would be great!

@omaciel
Copy link
Owner

omaciel commented Feb 20, 2018

@evgeni done. Version 2.1.2 will include only the change you submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants