Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Uri get generated without the signuture #8

Closed
Qandil opened this issue Aug 27, 2015 · 9 comments
Closed

Some Uri get generated without the signuture #8

Qandil opened this issue Aug 27, 2015 · 9 comments
Labels

Comments

@Qandil
Copy link

Qandil commented Aug 27, 2015

Hi,

Try getting ?v=RgKAFK5djSk you will notice flv doesnt have that signature.

@jamesqo
Copy link
Collaborator

jamesqo commented Aug 27, 2015

@Qandil Sorry, can you please clarify what you're saying? I just tried downloading that video, but I'm getting a 403 error (Forbidden) from HttpClient; I can't tell what you mean by "signature."

@Qandil
Copy link
Author

Qandil commented Aug 27, 2015

@jamesqo if you try with another video that does really work for flv extension you will notice that the uri has a parameter called signature which its seems to authenticate the request,

For some reason this parameter is not there, maybe something wrong parsing the video links ?

@jamesqo
Copy link
Collaborator

jamesqo commented Aug 30, 2015

Looks like this seems to be the piece of code in question; the "signature" parameter won't get added unless "s" or "sig" was there before. Maybe this is part of the problem; I'll investigate it further tomorrow. Thanks, Qandil.

@jamesqo
Copy link
Collaborator

jamesqo commented Sep 19, 2015

@Qandil Hey! Just pushed a new commit (7dadee8) that should fix this. It seems to be working for me now, can you verify that you're able to download the video with the newer package?

@Qandil
Copy link
Author

Qandil commented Sep 21, 2015

@jamesqo thank you for the update i guess i need to migrate to the new version before i test, right now i keep getting Cannot access a disposed object. Object name: 'System.Net.Http.HttpClient'.

@Qandil
Copy link
Author

Qandil commented Sep 21, 2015

Hi @jamesqo, try using the video i mentioned in the first comment, and try this:

service.GetAllVideos(videoUri)
           .Where(x => x.Format == VideoFormat.Flash && x.AudioBitrate > 0)
           .FirstOrDefault();

You will notice that the video.uri throws an exception which yet i don't know why, but maybe it is related.

@Qandil Qandil closed this as completed Sep 21, 2015
@Qandil Qandil reopened this Sep 21, 2015
@Qandil
Copy link
Author

Qandil commented Sep 21, 2015

Closed it by mistake

@aloisdg
Copy link

aloisdg commented Sep 21, 2015

@Qandil

service.GetAllVideos(videoUri)
    .Where(x => x.Format == VideoFormat.Flash && x.AudioBitrate > 0)
    .FirstOrDefault();

cloud be write

service.GetAllVideos(videoUri)
    .FirstOrDefault(x => x.Format == VideoFormat.Flash && x.AudioBitrate > 0);

@jamesqo
Copy link
Collaborator

jamesqo commented Sep 21, 2015

@aloisdg No, I'm afraid Qandil is right. Opened up a new issue at #16, let's talk about it there.

@jamesqo jamesqo closed this as completed Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants