strict() on zod objects within union #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR @kristinlindquist At any rate, this solution works for now. Until further research. |
BitPhoenix
pushed a commit
to BitPhoenix/prisma-zod-generator
that referenced
this pull request
Oct 28, 2022
…trict-on-zod-within-union strict() on zod objects within union
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding '.strict()' to the Zod objects within a union type, which appears to keep Zod from stripping properties via non-matching elements of the union.
Not sure if there are reasons to avoid
stricthere. If so, this PR may not be an appropriate solution for the problem. Additionally, this seems like questionable behavior on Zod's part and thus the "real fix" may be within Zod.References
Fixes #16