Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log files are not opened inside the chroot #24

Closed
chenein opened this issue Mar 3, 2024 · 2 comments
Closed

log files are not opened inside the chroot #24

chenein opened this issue Mar 3, 2024 · 2 comments

Comments

@chenein
Copy link

chenein commented Mar 3, 2024

Got gmid going today on my FBSD server with the chroot configuation. Wanted to use a text logfile. At first I created the path within the chroot but server couldn't open it. Realized it may be an exception to chroot, created in the main filesystem and it worked.

The documentation for the chroot option currently reads "All the paths in the configuration file are relative to the chroot directory, except for the cert, key and ocsp paths." Also the log access option says "The path is relative to the chroot."

My experience is that this is misleading, and a change to the documentation may be warranted. Alternatively, if the plan is to open the logfile within the chroot, this is not my experience.

omar-polo added a commit that referenced this issue Mar 3, 2024
Reported by Colin Henein, thanks!

See #24
omar-polo added a commit that referenced this issue Mar 3, 2024
We should open the log file inside the chroot; missed in
4acf495.

See #24
@omar-polo
Copy link
Owner

Oops, I got confused for a moment, please ignore 9f1cce3, I just reverted it. The real fix is in 248fb83.

I actually wanted to follow OpenBSD' httpd behaviour and open the log files inside the chroot; in this case the documentation was right and the code had a bug.

Thanks for the report!

@omar-polo omar-polo changed the title Document that path to log file is not relative to chroot log files are not opened inside the chroot Mar 3, 2024
@omar-polo
Copy link
Owner

I'm about to close this issues since 2.0.2 was released and includes this bugfix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants