Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hiding speed of bottom drop the same as top #41

Merged
merged 1 commit into from Oct 18, 2022
Merged

Make hiding speed of bottom drop the same as top #41

merged 1 commit into from Oct 18, 2022
+1 −1

Conversation

maiyama18
Copy link
Contributor

Thanks for creating great project.

I found that hiding speed of drops is too fast when position is .bottom. This PR makes hiding speed of bottom drops the same as top. Please close this PR if the current behavior is intentional.

before after top (for reference)
2022-10-18 14 28 51 2022-10-18 14 30 09 2022-10-18 14 29 19

omaralbeik
omaralbeik approved these changes Oct 18, 2022
View reviewed changes
Copy link
Owner

@omaralbeik omaralbeik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Lets Get This Merged ™

@omaralbeik omaralbeik added the bug Something isn't working label Oct 18, 2022
@omaralbeik omaralbeik merged commit f4eabe3 into omaralbeik:main Oct 18, 2022
@maiyama18 maiyama18 deleted the fix/bottom-hide-speed branch October 18, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omaralbeik omaralbeik omaralbeik approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maiyama18 @omaralbeik