Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Callback to set #1

Merged
merged 1 commit into from
Nov 22, 2023
Merged

feat: Add Callback to set #1

merged 1 commit into from
Nov 22, 2023

Conversation

tcarac
Copy link
Collaborator

@tcarac tcarac commented Nov 22, 2023 •
edited

  • Adding a callback to set so you don't need to assign value
  • Ensuring constructor has an initial value
  • Adding filtering to notify on conditions only

@tcarac tcarac force-pushed the tcarac/fx branch 2 times, most recently from bdb88c7 to bc9dbf7 Compare November 22, 2023 21:46
@tcarac tcarac requested a review from omarluq November 22, 2023 21:47
@tcarac tcarac marked this pull request as ready for review November 22, 2023 21:49
omarluq
omarluq approved these changes Nov 22, 2023
View reviewed changes
Copy link
Owner

@omarluq omarluq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@omarluq omarluq merged commit d174ffa into main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarluq omarluq omarluq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tcarac @omarluq