feat: Implemented setStoreValue method in controllers and added warnings for direct store access inside controllers #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarluq
force-pushed
the
add-setStoreValue-helper
branch
3 times, most recently
from
238403f
to
c550a21
Compare
omarluq
force-pushed
the
add-setStoreValue-helper
branch
4 times, most recently
from
a1b2c00
to
e06d679
Compare
…ngs for direct store access inside controllers
omarluq
force-pushed
the
add-setStoreValue-helper
branch
from
a2b2a1d
to
56c89be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR:
Introduces setStoreValue method in controllers. This method provides a more intuitive and safer way to update store values, as compared to directly manipulating the store.
Introduces warnings for direct store access from controllers. This is an important step towards enforcing best practices and preventing potential state management issues.