Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to view comments with JS disabled #204

Closed
omarroth opened this issue Oct 15, 2018 · 6 comments
Closed

Allow users to view comments with JS disabled #204

omarroth opened this issue Oct 15, 2018 · 6 comments
Labels
enhancement Improvement of an existing feature

Comments

@omarroth
Copy link
Contributor

Currently Invidious uses Javascript to decrease first page load for the /watch page. Unfortunately, this means that users cannot view comments if they have Javascript disabled.

Likely through a config option, (or if it's possible to redirect users with Javascript disabled) users would be directed to a page that loads everything initially, which will result in higher load time but allow users to view more content on the page without JS.

Originally posted by @Jtasiu in #132 (comment)

@omarroth omarroth added the enhancement Improvement of an existing feature label Oct 21, 2018
@omarroth
Copy link
Contributor Author

Added with 19516ea. It will respect a user's preferred comments. Some information is currently missing, which will be added soon with a refactor most likely.

@Jtasiu
Copy link

Jtasiu commented Nov 3, 2018

Thanks @omarroth. Wondering how to use this..do I add &nojs=1 into the url?

@omarroth
Copy link
Contributor Author

omarroth commented Nov 4, 2018

Yep, that should work fine. If you have JS disabled you should also see a message like this:
image

and clicking will add &nojs=1.

@Jtasiu
Copy link

Jtasiu commented Nov 9, 2018

I noticed clicking view replies doesn't show the reply comments. I'm guessing it's a bug or maybe it's something that will be part of the refactor?

@omarroth
Copy link
Contributor Author

Replies are normally loaded with JS as well, although hopefully it will be possible to load them initially after a refactor. Whatever the case I will be sure to provide an update here.

@omarroth
Copy link
Contributor Author

omarroth commented Apr 1, 2019

Keeping this closed in favor of #409.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants