Add user preferences #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved dark mode into user preferences. User can change video quality, volume, default speed, looping, dark mode, and autoplay.
Looks like it would close #6 and close #7.
Currently the quality options are fairly limited: "hd720", "medium", "small". This will likely be fixed on the way to implementing #5. For now, it works as expected on videos that have the preferred quality. An option for audio quality (for audio-only) should also probably be added.
Once #1 is implemented, an option should be added so the user can toggle between Reddit and YouTube comments.
Wondering if any other preferences should be added in this PR.