Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection#search #4

Closed
wants to merge 3 commits into from
Closed

Collection#search #4

wants to merge 3 commits into from

Conversation

leanucci
Copy link

This commit implements basic access to the search method of the MercadoPago API. Pagination and dating need special validation/documentation that will be added in future commits.

payment = mp_client.create_preference(data)


payment = mp_client.create_preference(access_token, data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client doesn't need to receive an access_token, because it is stored in an instance variable (token) inside the client. So, I think this documentation change is not correct, right?

@rafaelivan
Copy link
Contributor

leanucci, thanks for the pull request!

I have commented on a few lines of your commits.
I think it would be good to implement a search method on the client, which access the other modules of the gem. The idea of the client is to encourage the programmer to use only the client instead of accessing the individual modules directly and having to keep the access_token.

Thanks again, and I will wait for your comments!

@rafaelivan
Copy link
Contributor

The changes suggested by this pull request were incorporated in version 2.0.0.

@rafaelivan rafaelivan closed this Dec 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants