Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the mp_client.search(search_hash) method to the collection #6

Closed
wants to merge 5 commits into from

Conversation

cavi21
Copy link

@cavi21 cavi21 commented Oct 17, 2012

Inspired in @leanucci pull request, I minimize the changes, only add the method in the Collection and in the Client, also add the minitest.

Sorry for this double pull request on the same topic, not sure how is the way to add this to the other one.

Thanks

@cavi21
Copy link
Author

cavi21 commented Oct 20, 2012

I just add the documentation of the search also in the README file.

Just to letting you know
Thanks

@rafaelivan
Copy link
Contributor

Sorry for taking so long to merge these changes.

As the test credentials were not working anymore, I had to change the test account. So, I made a new commit manually including your changes. I also refactored a few things.

@rafaelivan rafaelivan closed this Dec 21, 2012
@cavi21
Copy link
Author

cavi21 commented Dec 22, 2012

@rafaelivan hey no problem at all! great that you merge this in your repo. Also I contact MP here in Argentina and they deliver a ruby wrapper as a lib a few months ago: https://github.com/mercadopago/sdk-ruby I asked them why not collaborate in your gem, and had no response, just to let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants