Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package React with Addons #59

Closed
the-kenny opened this issue Jan 16, 2014 · 12 comments

Comments

Projects
None yet
5 participants
@the-kenny
Copy link

commented Jan 16, 2014

The addons package provide some useful things like TransitionGroup (for CSS Animation).

The size difference of both is negligible (458736 vs. 492606 bytes), so it should be safe to include instead of the 'basic' react.

@the-kenny

This comment has been minimized.

Copy link
Author

commented Jan 16, 2014

Support for TransitionGroup in om.dom would be useful too - I volunteer if no one else needs this)

@swannodette

This comment has been minimized.

Copy link
Member

commented Jan 16, 2014

I'll update the React JAR on Clojars to include it.

@swannodette

This comment has been minimized.

Copy link
Member

commented Jan 18, 2014

Ok I think the problem with including add ons is that I believe you'll need externs for them. I guess users can supply these themselves?

@the-kenny

This comment has been minimized.

Copy link
Author

commented Jan 18, 2014

How are the externs for the normal react package generated? Can't we do the
same for -with-addons?
Am 18.01.2014 22:17 schrieb "David Nolen" notifications@github.com:

Ok I think the problem with including add ons is that I believe you'll
need externs for them. I guess users can supply these themselves?


Reply to this email directly or view it on GitHubhttps://github.com//issues/59#issuecomment-32693405
.

@swannodette

This comment has been minimized.

Copy link
Member

commented Jan 19, 2014

We borrowed them from a JavaScript project that created them for React. So they will need to be made for the add-ons via a tool or by hand.

@zentrope

This comment has been minimized.

Copy link

commented Feb 10, 2014

Any movement on this?

If know one knows how to make the externs, maybe someone could document how to include the add on stuff by hand?

@ul

This comment has been minimized.

Copy link

commented Feb 10, 2014

@zentrope in build config point out addons js in :preamble after "react/react.min.js" (file should be inside source-paths AFAIR) and externs in :externs (file should be outside source-paths or you get duplicate error AFAIR) together with "react/externs/react.js"

@danielsz danielsz referenced this issue Mar 3, 2014

Closed

CSS transitions #129

@swannodette

This comment has been minimized.

Copy link
Member

commented Mar 4, 2014

This is not an Om issue, I created a repo for the React JAR that I deploy to Clojars http://github.com/swannodette/react-cljs.

@swannodette swannodette closed this Mar 4, 2014

@swannodette

This comment has been minimized.

Copy link
Member

commented Mar 4, 2014

@steida

This comment has been minimized.

Copy link

commented May 10, 2014

Hi, I extracted React.js externs from Este.js
https://github.com/steida/react-externs

Add-ons are ommited, because their api is experimental, so you should use [] syntax for it.

@swannodette

This comment has been minimized.

Copy link
Member

commented May 10, 2014

@steida this is already taken care of by https://github.com/swannodette/react-cljs. Is there something missing for you there?

@steida

This comment has been minimized.

Copy link

commented May 10, 2014

No. I just wanted to leave link to plain React.js externs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.